change all url strings to URI type #79
Conversation
DarthKipsu
changed the title
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| import com.google.gson.JsonArray; | |||
| import com.google.gson.JsonObject; | |||
| import java.net.URI; | |||
|
|
|||
| import java.util.Map; | |||
There was a problem hiding this comment.
Nit: The empty line should be between the java and com.google import groups, not inside the java group.
|
Added some (Mostly small and superficial) comments. Nice work! For details on import ordering, see https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing. Just mentally replace |
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| import com.github.tomakehurst.wiremock.client.WireMock; | |||
| import com.github.tomakehurst.wiremock.junit.WireMockRule; | |||
| import java.net.URI; | |||
|
Two more import order notes, LGTM when those are fixed. |
| @@ -61,13 +61,13 @@ public Course call() throws TmcCoreException, URISyntaxException { | |||
|
|
|||
| if (!course.isPresent()) { | |||
| throw new TmcCoreException( | |||
| "Attempted to fetch nonexistent course " + urlWithApiVersion); | |||
| "Attempted to fetch nonexistent course " + urlWithApiVersion); | |||
| } | ||
| return argument.toString().contains(search); | ||
| } | ||
| } |
There was a problem hiding this comment.
Indented with tabs, lets make it to use spaces (you can configure your IDE not to use tabs)
|
Could you please merge this or comment if there's still something to review. |
|
Sorry for the delay, we only get a notice when there's a new comment, not when you push new commits to the branch. LGTM. We'll merge after @jamox has taken a look as well (likely during tomorrow). |
|
LGTM, nice work. |
Change all uri like strings to URI type
Fixes #77